Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

implement PDP url for product variant #708

Merged
merged 11 commits into from
May 19, 2020
Merged

implement PDP url for product variant #708

merged 11 commits into from
May 19, 2020

Conversation

AlicjaSzu
Copy link
Contributor

@AlicjaSzu AlicjaSzu commented May 12, 2020 •
edited
Loading

I want to merge this change because...

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@AlicjaSzu AlicjaSzu added the wip Work in progress label May 12, 2020
@AlicjaSzu AlicjaSzu self-assigned this May 12, 2020
@netlify
Copy link

netlify bot commented May 12, 2020 •
edited
Loading

Deploy preview for saleor-storefront-stage processing.

Building with commit 0f88ecf

https://app.netlify.com/sites/saleor-storefront-stage/deploys/5ec3a8f36c14ef00063127e6

@lgtm-com
Copy link

lgtm-com bot commented May 13, 2020

This pull request fixes 1 alert when merging 400c432 into 775ead6 - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@lgtm-com
Copy link

lgtm-com bot commented May 13, 2020

This pull request fixes 1 alert when merging fe7a578 into 775ead6 - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2020

This pull request fixes 1 alert when merging cead073 into 6f5517c - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2020

This pull request fixes 1 alert when merging f351aab into 6f5517c - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@AlicjaSzu AlicjaSzu changed the title start implementing PDP url for product variant implement PDP url for product variant May 14, 2020
@lgtm-com
Copy link

lgtm-com bot commented May 14, 2020

This pull request fixes 1 alert when merging 4092559 into 6f5517c - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@AlicjaSzu AlicjaSzu removed the wip Work in progress label May 14, 2020
@AlicjaSzu AlicjaSzu requested a review from orzechdev May 14, 2020 15:39
@lgtm-com
Copy link

lgtm-com bot commented May 15, 2020

This pull request fixes 1 alert when merging 501513e into 6f5517c - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

orzechdev
orzechdev reviewed May 15, 2020
View reviewed changes
src/@next/components/organisms/ProductVariantPicker/types.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented May 15, 2020

This pull request fixes 1 alert when merging b2284d0 into 6f5517c - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@lgtm-com
Copy link

lgtm-com bot commented May 15, 2020

This pull request fixes 1 alert when merging e0da5f4 into 6f5517c - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request fixes 1 alert when merging 0f88ecf into d4e122e - view on LGTM.com

fixed alerts:

  • 1 for Potentially unsafe external link

@AlicjaSzu AlicjaSzu merged commit 8be7931 into master May 19, 2020
@AlicjaSzu AlicjaSzu deleted the feature/pdp-url branch May 19, 2020 10:06
@krzysztofwolski krzysztofwolski mentioned this pull request May 27, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dominik-zeglen dominik-zeglen dominik-zeglen left review comments

@orzechdev orzechdev orzechdev left review comments

Assignees

@AlicjaSzu AlicjaSzu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlicjaSzu @dominik-zeglen @orzechdev